-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Down #90
Comments
is there any update on this? when it will get resolved? |
Hey guys, @badakhgovind, @redesigned, thanks for reporting. Meanwhile the API is back up |
@MartinsOnuoha I'd hold off on that.
The app hard crashes. I double checked locally and Node crashes. (So if you're around and awake you should restart the app)
This is just one route that I checked because I thought it had the potential to be expensive. I'm going to test all of these routes tonight and try to break them. Then I'm going to attempt to fix them. If you don't have any objections we can start off by wrapping all the routes in a try/catch block that just returns an HTTP 500 if the catch block gets triggered. That will prevent hard crashes. I would also recommend implementing default values for all parameters. Beyond that, it's going to be profiling the routes for time constraints. Anything over 30s is going to cause a 503 on Heroku. We could also implement caching to speed up repeated routes if you don't already have that. |
Hey Tim, @TimAagaard , many thanks for breaking the application and documenting your finding, from the logs on paper trail I could tell that a single request was what keeps breaking the application although I hadn’t gotten enough time to look into it yet because of work. I’m totally okay with us going this route and fixing any route with this possible failure. Generally we do need to handle long running requests and cache their responses too, this was another thing I hadn’t gotten around to doing yet (although I was particular about making external calls to 3rd party data source on application startup, so it’s not repeated for every request). I would also open an issue to move the application to Typescript, to make development even easier. Although this would be long-term and slow paced until we have a working TS version of the application. |
I’ll close this issue again and I’ve opened a new one with your comment quoted. #91 |
Not sure if this is the correct place to report this, but the API is currently down.
Thanks!
The text was updated successfully, but these errors were encountered: