Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed problem where runMain gbvga.GbVgaDriver failed #1

Merged
merged 1 commit into from Nov 3, 2020
Merged

fixed problem where runMain gbvga.GbVgaDriver failed #1

merged 1 commit into from Nov 3, 2020

Conversation

chick
Copy link
Contributor

@chick chick commented Nov 3, 2020

  • point sbt dependencies to snapshots instead of RC-1
  • Changed GbConst to trait
    • fixed up all references to GbConst
    • Think problem was bundles declared outside of modules
  • another approach might be to make GbConst its own module

@chick
fixed problem where runMain gbvga.GbVgaDriver failed
cbf01db 
- point sbt dependncies to snapshots instead of RC-1
- Changed GbConst to trait
  - Think problem was bundles declared outside of modules
  - another approach might be to make GbConst its own module
  - fixed up all references to GbConst
@Martoni
Copy link
Owner

Martoni commented Nov 3, 2020 •
edited

Thanks chick, in fact I changed chisel version to 3.4.0-RC1 because of chisel-formal module. I have some problem with it.
But using snapshot seems to be a good compromise.

I'm not really confortable with trait, but if you say that trait RawModule is the way to do it I will follow it.

@Martoni Martoni merged commit cbf01db into Martoni:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chick @Martoni