Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final code for v3.4.0 from Development #179

Merged
merged 16 commits into from
Jun 3, 2019
Merged

Final code for v3.4.0 from Development #179

merged 16 commits into from
Jun 3, 2019

Conversation

Marzogh
Copy link
Owner

@Marzogh Marzogh commented Jun 3, 2019

Any pull request raised here MUST be submitted according to here MUST be submitted according to this template or it will be flagged with 'Not enough information'. No action will be taken till all the prerequisite information (according to the right template) is provided. If no information is provided for over a month after the 'Not enough information' label is applied, the issue will be closed.

Pull request details

  • Please check if the PR fulfills these requirements
  • The commit message/s explain/s all the changes clearly
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Added feature
  • Documentation update
  • Other - Please explain here: Refer to change log
  • What is the current behavior? (You can also link to an open issue here)
    v3.3.0

  • What is the new behavior? (if this is a feature change)
    v3.4.0 - Refer to change log

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    setClockSpeed() now has to be called before flash.begin() and not after.

  • Other information:


DO NOT DELETE OR EDIT anything below this

Note 1: Make sure to add all the information needed to understand the bug so that someone can help. If any essential information is missing we'll add the 'Needs more information' label and close the issue until there is enough information.

Note 2: For support questions (for example, tutorials on how to use the library), please use the Arduino Forums. This repository's issues are reserved for feature requests and bug reports.


GitHub issue state GitHub issue title GitHub issue author GitHub issue label GitHub issue comments GitHub issue age GitHub issue last updateGitHub pull request check contexts

@Marzogh Marzogh added the minor version Minor version release. No breaking changes. label Jun 3, 2019
@Marzogh Marzogh added this to the v3.4.0 milestone Jun 3, 2019
@Marzogh Marzogh self-assigned this Jun 3, 2019
@todo
Copy link

todo bot commented Jun 3, 2019

- Set up other manufaturerIDs in a similar pattern.

} //TODO - Set up other manufaturerIDs in a similar pattern.
}
for (uint8_t j = 0; j < sizeof(_capID); j++) {
if (_chip.capacityID == _capID[j]) {
_chip.capacity = (_memSize[j]);


This comment was generated by todo based on a TODO comment in 106ae3f in #179. cc @Marzogh.

@Marzogh Marzogh merged commit 82db983 into stable Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor version Minor version release. No breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants