Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up other manufacturerIDs in a similar pattern. #181

Closed
todo bot opened this issue Jun 3, 2019 · 1 comment
Closed

Set up other manufacturerIDs in a similar pattern. #181

todo bot opened this issue Jun 3, 2019 · 1 comment
Assignees
@Marzogh
Labels
mid priority This is a mid-priority item and will be actioned in the near future todo 🗒️
Milestone
v3.5.0

Comments

@todo
Copy link

todo bot commented Jun 3, 2019 •
edited by Marzogh
Loading

SPIMemory/src/SPIFlashIO.cpp

Lines 582 to 586 in 106ae3f

} //TODO - Set up other manufaturerIDs in a similar pattern.
}
for (uint8_t j = 0; j < sizeof(_capID); j++) {
if (_chip.capacityID == _capID[j]) {
_chip.capacity = (_memSize[j]);

This issue was generated by todo based on a TODO comment in 106ae3f when #179 was merged. cc @Marzogh.

GitHub issue state GitHub issue title GitHub issue author GitHub issue label GitHub issue comments GitHub issue age GitHub issue last update
@todo todo bot assigned Marzogh Jun 3, 2019
@todo todo bot added the todo 🗒️ label Jun 3, 2019
@Marzogh Marzogh changed the title - Set up other manufaturerIDs in a similar pattern. - Set up other manufacturerIDs in a similar pattern. Jun 3, 2019
@Marzogh Marzogh changed the title - Set up other manufacturerIDs in a similar pattern. Set up other manufacturerIDs in a similar pattern. Jun 3, 2019
@Marzogh Marzogh added this to the v3.5.0 milestone Jun 3, 2019
@Marzogh Marzogh added the mid priority This is a mid-priority item and will be actioned in the near future label Jun 3, 2019
Marzogh added a commit that referenced this issue Jun 3, 2019
@Marzogh
Resolves #181
7367cef
@Marzogh Marzogh mentioned this issue Jun 3, 2019
Closed
@Marzogh
Copy link
Owner

Marzogh commented Jun 3, 2019

Will resolve #163 as well.

Marzogh added a commit that referenced this issue Jun 3, 2019
@Marzogh
Updated change log and speed comparisons doc. Fixes #163 Resolves #181
32341cc
@Marzogh Marzogh closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marzogh Marzogh

Labels
mid priority This is a mid-priority item and will be actioned in the near future todo 🗒️
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
1 participant
@Marzogh