Fixed docker container issue and added docker-compose file to simplify config #70
Conversation
| @@ -0,0 +1,3 @@ | |||
| npm install | |||
| npm install es6-promise | |||
There was a problem hiding this comment.
IMO it would be better to add this to package.json
There was a problem hiding this comment.
I thought of that but this would affect the application itself. I couldn't see any issue regarding using installable application (without docker) so thought it could be an issue with docker setup (like missing some libs in setup).
There was a problem hiding this comment.
Adding es6-promise resolved #62 because it is a dependency of this app from what I can tell. An npm install mockbin on a blank system yields the same error as the Docker build
|
I just downloaded this branch and built it, so far so good. I would suggest that @orasik build a new image on dockerhub so that people who go looking for it like I did find it. |
|
Are there still outstanding comments on this PR? Ran into this issue today and it would be great if this was merged |
|
For what it's worth I have a working image for Mockbin. I can push it to Docker Hub if anyone wants. Or you can build it yourself. The Dockerfile is: FROM node:10.21.0-buster
WORKDIR /usr/src/mockbin
RUN git clone https://github.com/Kong/mockbin.git /usr/src/mockbin
RUN cd /usr/src/mockbin \
&& npm install \
&& npm install es6-promise
RUN npm config set mockbin:redis redis://172.18.0.103:6379
EXPOSE 8080
CMD [ "npm", "start" ]You'll likely need to adjust the IP/name for Redis. |
issue