Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node security project failure #83

Closed
bobjflong opened this issue Feb 11, 2016 · 9 comments
Closed

Node security project failure #83

bobjflong opened this issue Feb 11, 2016 · 9 comments

Comments

@bobjflong
Copy link
Contributor

Hi, we are getting nsp failures in intercom-node. We are running unirest 0.4.2 which appears to be the latest. There was a change dddf899 to bump the request version but did it get released? And do you think it will fix the hawk issue?

┌───────────────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│               │ Regular Expression Denial of Service                                                                      │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Name          │ hawk                                                                                                      │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Installed     │ 1.1.1                                                                                                     │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Vulnerable    │ < 3.1.3  || >= 4.0.0 <4.1.1                                                                               │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Patched       │ >=3.1.3 < 4.0.0 || >=4.1.1                                                                                │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Path          │ intercom-client@2.6.0 > unirest@0.4.2 > request@2.51.0 > hawk@1.1.1                                       │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ More Info     │ https://nodesecurity.io/advisories/77                                                                     │
└───────────────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────┘
@joeycozza
Copy link

Sure would be nice to have this update released on npm...

@bobjflong
Copy link
Contributor Author

Our builds are still broken 😞 would it be possible to release the version? Or learn more about when that might happen?

@ErikBean
Copy link

ErikBean commented May 9, 2016

@bobjflong I bumped my unirest version to point to master:
"unirest": "git@github.com:Mashape/unirest-nodejs.git#master"
And nsp is no longer complaining about request, since it's bumped to ~2.65.0 in unirest's master branch.
So I believe this issue should be fixed in the next release.
I also would like to have this added to npm, how can I help?
@nijikokun is there a plan for when the next release might be out?

@nijikokun
Copy link
Contributor

nijikokun commented May 9, 2016 via email

@joeycozza
Copy link

hallelujah

@nijikokun
Copy link
Contributor

nijikokun commented May 9, 2016

0.5.0 has been released, beware that I have updated all module dependencies to their latest (safe) version that I can foresee. Let me know if you spot any issues.

 % nsp check                                                                                    git/unirest-nodejs (master) nijikokun
(+) No known vulnerabilities found

@ErikBean
Copy link

@nijikokun I'm confused, I don't see 0.5.0 in the releases page, but I see 0.5.0 on npm. How is this working?

@nijikokun
Copy link
Contributor

nijikokun commented May 10, 2016 via email

@ErikBean
Copy link

Ok, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants