failing to compile on macOS High Seirria on latest commit

[CSRaghunandan]

Getting the below error when I try to install ccls with the latest commit. Also, I installed LLVM 7.0 recently. Not sure if that's causing the error?

==> cmake -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX
==> cmake --build Release --target install
Last 15 lines from /Users/csraghunandan/Library/Logs/Homebrew/ccls/02.cmake:
  "clang::tooling::HeaderIncludes::HeaderIncludes(llvm::StringRef, llvm::StringRef, clang::tooling::IncludeStyle const&)", referenced from:
      clang::format::cleanupAroundReplacements(llvm::StringRef, clang::tooling::Replacements const&, clang::format::FormatStyle const&) in libclangFormat.a(Format.cpp.o)
  "clang::tooling::IncludeCategoryManager::IncludeCategoryManager(clang::tooling::IncludeStyle const&, llvm::StringRef)", referenced from:
      clang::format::sortCppIncludes(clang::format::FormatStyle const&, llvm::StringRef, llvm::ArrayRef<clang::tooling::Range>, llvm::StringRef, clang::tooling::Replacements&, unsigned int*) in libclangFormat.a(Format.cpp.o)
  "clang::tooling::HeaderIncludes::insert(llvm::StringRef, bool) const", referenced from:
      clang::format::cleanupAroundReplacements(llvm::StringRef, clang::tooling::Replacements const&, clang::format::FormatStyle const&) in libclangFormat.a(Format.cpp.o)
  "clang::tooling::HeaderIncludes::remove(llvm::StringRef, bool) const", referenced from:
      clang::format::cleanupAroundReplacements(llvm::StringRef, clang::tooling::Replacements const&, clang::format::FormatStyle const&) in libclangFormat.a(Format.cpp.o)
  "clang::tooling::IncludeCategoryManager::getIncludePriority(llvm::StringRef, bool) const", referenced from:
      clang::format::sortCppIncludes(clang::format::FormatStyle const&, llvm::StringRef, llvm::ArrayRef<clang::tooling::Range>, llvm::StringRef, clang::tooling::Replacements&, unsigned int*) in libclangFormat.a(Format.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [ccls] Error 1
make[1]: *** [CMakeFiles/ccls.dir/all] Error 2
make: *** [all] Error 2

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/twlz0ne/homebrew-ccls/issues

[MaskRay]

clangToolingInclusions should be dependend if the clang libraries were built with -DBUILD_SHARED_LIBS=off

Fixed with

# TODO Remove after dropping clang 6
_Clang_find_library(clangToolingInclusions_LIBRARY clangToolingInclusions)
if (clangToolingInclusions_LIBRARY)
  list(APPEND _Clang_LIBRARIES ${clangToolingInclusions_LIBRARY})
endif()