Merge 2b1dbd2 into 43812f4

MasoniteFramework · Feb 16, 2019 · abc1512 · abc1512
2 parents 43812f4 + 2b1dbd2
commit abc1512
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 0 deletions.
diff --git a/masonite/exception_handler.py b/masonite/exception_handler.py
@@ -77,6 +77,7 @@ def handle(self, exception):
         self.response.view(self._app.make('View')('/masonite/snippets/exception',
                                                {
                                                    'exception': self._exception,
+                                                   'split_exception': str(self._exception).split(' '),
                                                    'traceback': traceback,
                                                    'tb': sys.exc_info(),
                                                    'app': self._app,

diff --git a/masonite/response.py b/masonite/response.py
@@ -101,6 +101,9 @@ def view(self, view, status=200):
         elif view is None:
             raise ResponseError('Responses cannot be of type: None.')
 
+        if not isinstance(view, str):
+            raise ResponseError('Invalid response type of {}'.format(type(view)))
+
         self.app.bind('Response', view)
 
         self.make_headers()

diff --git a/masonite/snippets/exception.html b/masonite/snippets/exception.html
@@ -26,6 +26,8 @@
                         <li><a href="#Request">Request</a></li>
                         <li><a href="#Container">Container</a></li>
                         <li><a href="{{ app.make('Request').path }}">Try Again</a></li>
+                        <li><a href="https://stackoverflow.com/search?q=masonite+{{ split_exception|join('+') }}" target="_blank"><img src="/_exceptions/css/so-icon.png" style="width: 20px" /> Stack Overflow</a></li>
+                        <li><a href="https://www.google.com/search?q=masonite+{{ split_exception|join('+') }}" target="_blank"><img src="/_exceptions/css/go-icon.png" style="width: 20px" /> Google</a></li>
                     </ul>
                 </div>
             </div>

diff --git a/masonite/snippets/exceptions/css/go-icon.png b/masonite/snippets/exceptions/css/go-icon.png
diff --git a/masonite/snippets/exceptions/css/so-icon.png b/masonite/snippets/exceptions/css/so-icon.png