Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follows pep257 #433

Merged
merged 13 commits into from
Oct 10, 2018
Merged

Follows pep257 #433

merged 13 commits into from
Oct 10, 2018

Conversation

vaibhavmule
Copy link
Contributor

@vaibhavmule vaibhavmule commented Oct 8, 2018 •
edited
Loading

This way, we can have consistency over docstrings.

I have followed various convention suggested by pep257 through https://gist.github.com/dolph/39d8f70cab6afbac8c01#file-good_docstrings-py

@vaibhavmule vaibhavmule requested a review from a team October 8, 2018 18:58
@coveralls
Copy link

coveralls commented Oct 8, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-1.8%) to 90.072% when pulling aad5b76 on vaibhavmule:pep-257 into 39f7b79 on MasoniteFramework:develop.

@josephmancuso josephmancuso merged commit 40715fb into MasoniteFramework:develop Oct 10, 2018
@vaibhavmule vaibhavmule mentioned this pull request Oct 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaibhavmule @coveralls @josephmancuso