Fix/496 - Fix controller's name when in creation by craft controller there the slash between folder and controller's name. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slash between folder and controller's name.
josephmancuso
changed the title
|
We should be able to do this in a cleaner way ill have to take a look. This is a little messy tbh. |
josephmancuso
approved these changes
Jan 20, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496
Fix controller's name when in creation by craft controller there the slash between folder and controller's name.
I've tried handle relative paths with controllers_path() from better way 😅
Maybe needed a refactor just let me know.
@josephmancuso I would implement tests, but I didn't found any tests for commands for now in project.