Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AuthenticatorDevice type and usage #558

Closed
MasterKale opened this issue Apr 13, 2024 · 0 comments · Fixed by #625
Closed

Rename AuthenticatorDevice type and usage #558

MasterKale opened this issue Apr 13, 2024 · 0 comments · Fixed by #625

Comments

@MasterKale
Copy link
Owner

Describe the issue

I don't like that the "authenticator" argument in verifyAuthenticationResponse() is of type "AuthenticatorDevice". I decided these names four years ago, and in retrospect it should have been called something like Credential instead even back then. I'm updating docs for the v10 release right now and it's really standing out as an odd choice in naming.

Next major release consider renaming these two to reflect changes in the ecosystem since 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant