Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Sonar Issues #35

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Removing Sonar Issues #35

merged 1 commit into from
Jun 16, 2022

Conversation

rfeelin
Copy link
Contributor

@rfeelin rfeelin commented Jun 15, 2022

PR checklist

  • [-] An issue/feature request has been created for this PR
    Just cleaning up code duplication for Sonar
  • Pull Request title clearly describes the work in the pull request and the Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response.
  • File the PR against the master branch
  • The code in this PR is covered by unit tests

Link to issue/feature request: None just doing a code cleanip

Description

Sonar was running into issues with duplication code. This removes it.

@rfeelin rfeelin added the safe The PR has been reviewed by Mastercard and has been validated to be safe label Jun 16, 2022
@rfeelin rfeelin merged commit a9f8a5f into Mastercard:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danny-gallagher danny-gallagher danny-gallagher approved these changes

Assignees
No one assigned
Labels
safe The PR has been reviewed by Mastercard and has been validated to be safe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfeelin @danny-gallagher @rossphelan