Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to webpack 5 #54

Closed
wants to merge 1 commit into from
Closed

upgrade to webpack 5 #54

wants to merge 1 commit into from

Conversation

joseph-neeraj
Copy link
Contributor

PR checklist

  • [ x] An issue/feature request has been created for this PR
  • [ x] Pull Request title clearly describes the work in the pull request and the Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response.
  • [x ] File the PR against the master branch
  • The code in this PR is covered by unit tests

Link to issue/feature request: add the link here

Description

A clear and concise description of what is this PR for and any additional info might be useful for reviewing it.

NehaSony
NehaSony approved these changes May 25, 2023
View reviewed changes
Copy link

@NehaSony NehaSony left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like build is failing

@joseph-neeraj
Copy link
Contributor Author

closing this as webpack5's support for nodejs 10 is flaky as can be seen from the build action failing for node10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NehaSony NehaSony NehaSony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-neeraj @NehaSony