Implement more options, for p11kcv
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EditUndo
reviewed
Apr 23, 2024
EditUndo
reviewed
Apr 23, 2024
EditUndo
reviewed
Apr 23, 2024
EditUndo
reviewed
Apr 23, 2024
EditUndo
reviewed
Apr 23, 2024
EditUndo
reviewed
Apr 23, 2024
Removing whitespace.
Removing whitespace.
EditUndo
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Green lighting because these are tactical changes, but in a future commit we should:
-
Remove mac_algo_t; atleast from the main header because it only appears to be used in kcv logic. We can pass the string directly and process it in the kcv lib.
-
Reduce the size of large functions in the kcv lib; bulky functions make the logic difficult to follow.
-
Reduce the number of preallocated mechanisms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following features:
CKA_CHECK_VALUEcan be used (when present)This PR should address the requests from issue #59.