Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to favourites not updating favourite folder #2

Open
Mastersam07 opened this issue Jan 23, 2023 · 1 comment
Open

Adding to favourites not updating favourite folder #2

Mastersam07 opened this issue Jan 23, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Mastersam07
Copy link
Owner

Adding a package to a favorite is meant to update the favorite folder in bookmarks. However, it tends to create a new folder and add the package bookmark to that folder.

Implications:
For 10 added packages, that would be 10 folders with the same name housing one package each instead of 1 folder with 10 packages.

@Mastersam07 Mastersam07 added bug Something isn't working good first issue Good for newcomers labels Jan 23, 2023
@Mastersam07
Copy link
Owner Author

From the background script:

chrome.bookmarks.create({ 'parentId': '1', 'title': 'Flutter/Dart Packages' });

The above is called, and the folder id passed down to add the package to this folder. A fix would be to check if a bookmark folder with that name exists then create a new bookmark in that folder or a more like createIfNotExist solution that creates if the folder doesn't exist or just put if already exist.

@Mastersam07 Mastersam07 added the help wanted Extra attention is needed label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant