Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogHost on MetroWindow causes rendering artifacts #1198

Closed
Tokter opened this issue Feb 25, 2019 · 5 comments
Closed

DialogHost on MetroWindow causes rendering artifacts #1198

Tokter opened this issue Feb 25, 2019 · 5 comments

Comments

@Tokter
Copy link
Contributor

Tokter commented Feb 25, 2019

As you move your mouse around, or tab between different controls. Horizontal and vertical lines appear:

image

You can recreate the issue by adding a DialogHost to the MahAppsDragablzDemo MainWindow.xaml

<controls:MetroWindow x:Class="MahMaterialDragablzMashUp.MainWindow"
                      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                      xmlns:controls="http://metro.mahapps.com/winfx/xaml/controls"
                      xmlns:dragablz="clr-namespace:Dragablz;assembly=Dragablz"
                      xmlns:mahMaterialDragablzMashUp="clr-namespace:MahMaterialDragablzMashUp"
                      xmlns:dockablz="clr-namespace:Dragablz.Dockablz;assembly=Dragablz"
                      xmlns:wpf="http://materialdesigninxaml.net/winfx/xaml/themes"                      
                      WindowTransitionsEnabled="False"
                      TextElement.Foreground="{DynamicResource MaterialDesignBody}"
                      Background="{DynamicResource MaterialDesignPaper}"					  
                      GlowBrush="{DynamicResource AccentColorBrush}"					  
                      FontFamily="{StaticResource DefaultFont}"
                      Title="Material-MahApps-Dragablz Mash Up" Height="640" Width="800">
    
    <controls:MetroWindow.Flyouts>
        <controls:FlyoutsControl>
            <controls:Flyout x:Name="LeftFlyout" Position="Left" Header="Settings" wpf:FlyoutAssist.HeaderColorMode="Accent">
                <mahMaterialDragablzMashUp:FlyoutContent />
            </controls:Flyout>
        </controls:FlyoutsControl>
    </controls:MetroWindow.Flyouts>
    <controls:MetroWindow.LeftWindowCommands>
        <controls:WindowCommands>
            <wpf:PopupBox Style="{StaticResource WindowCommandsPopupBoxStyle}">
                <StackPanel>
                    <Button Content="Hello World"/>
                    <Button Content="Nice Popup"/>
                    <Button Content="Goodbye"/>
                </StackPanel>
            </wpf:PopupBox>
        </controls:WindowCommands>
    </controls:MetroWindow.LeftWindowCommands>

    <wpf:DialogHost IsOpen="True">
        <wpf:DialogHost.DialogContent>
            <DockPanel VerticalAlignment="Center" HorizontalAlignment="Center" Margin="20" FocusManager.IsFocusScope="True">
                <StackPanel DockPanel.Dock="Bottom" Orientation="Horizontal" HorizontalAlignment="Right">
                    <Button x:Name="Cancel" Style="{StaticResource MaterialDesignFlatButton}">Cancel</Button>
                    <Button x:Name="Add" Style="{StaticResource MaterialDesignFlatButton}">Add</Button>
                </StackPanel>
                <StackPanel Orientation="Vertical">
                    <TextBlock Margin="8" DockPanel.Dock="Top" Text="Dialog Test" TextWrapping="Wrap" Style="{StaticResource MaterialDesignHeadlineTextBlock}" />
                    <TextBox Text="Line 1" Margin="8,8,8,0" wpf:HintAssist.Hint="Test" Style="{StaticResource MaterialDesignFloatingHintTextBox}" />
                    <TextBox Text="Line 2" Margin="8,8,8,0" wpf:HintAssist.Hint="Test" Style="{StaticResource MaterialDesignFloatingHintTextBox}" />
                    <TextBox Text="Line 3" Margin="8,8,8,0" wpf:HintAssist.Hint="Test" Style="{StaticResource MaterialDesignFloatingHintTextBox}" />
                </StackPanel>
            </DockPanel>
        </wpf:DialogHost.DialogContent>


        <dockablz:Layout>
            <dragablz:TabablzControl BorderThickness="0"
                                 Margin="0,-1,0,1">
                <dragablz:TabablzControl.InterTabController>
                    <dragablz:InterTabController />
                </dragablz:TabablzControl.InterTabController>
                <TabItem Header="DIALOGS">
                    <mahMaterialDragablzMashUp:Dialogs Margin="8">
                        <mahMaterialDragablzMashUp:Dialogs.DataContext>
                            <mahMaterialDragablzMashUp:DialogsViewModel />
                        </mahMaterialDragablzMashUp:Dialogs.DataContext>
                    </mahMaterialDragablzMashUp:Dialogs>
                </TabItem>
                <TabItem Header="MAHAPPS">
                    <mahMaterialDragablzMashUp:Mah Margin="16" />
                </TabItem>
                <TabItem Header="PALETTE">
                    <mahMaterialDragablzMashUp:PaletteSelector Margin="16">
                        <mahMaterialDragablzMashUp:PaletteSelector.DataContext>
                            <mahMaterialDragablzMashUp:PaletteSelectorViewModel />
                        </mahMaterialDragablzMashUp:PaletteSelector.DataContext>
                    </mahMaterialDragablzMashUp:PaletteSelector>
                </TabItem>
            </dragablz:TabablzControl>
        </dockablz:Layout>
    </wpf:DialogHost>
</controls:MetroWindow>
@alonfnt
Copy link
Contributor

alonfnt commented Feb 25, 2019

I was going to create an issue with this exact Bug.
I have a simple repo that recreates the glitches when using MetroWindow and Material Dialog
Repo

@jespersh
Copy link
Contributor

jespersh commented Feb 26, 2019

Duplicate of issue #1097
See comment #1097 (comment)

@Tokter
Copy link
Contributor Author

Tokter commented Feb 26, 2019

Looks like it, but since that issue only started with one of the latest updates and multiple people seem to run into it. Maybe that should be fixed somewhere in the framework?

@Keboo
Copy link
Member

Keboo commented Feb 26, 2019

@Tokter do you know a previous version where it worked?

@Tokter
Copy link
Contributor Author

Tokter commented Feb 26, 2019

@Keboo Couldn't figure out in what version it changed yet. But I created a pull request that I think fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants