-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #1097 & #1198 Adding a UseLayoutRounding=True to the DialogHost #1199
Conversation
Should this also get applied to the |
Is DialogHost the root element? I forgot if it is. |
@jespersh that is an excellent point. Usually the dialog host is a root level element inside of the window but it doesn't have to be (the demo app shows this case).
|
@Keboo Your suggestion in point 1 works, UseLayoutRounding appear on the root element: |
I guess you could say that if you use the embedded dialog, then its up to the user to add a UseLayoutRounding on the MainWindow. |
@Tokter yea I think simply documenting that behavior for the embedded dialog host is the way to go. I have been working on trying to update the wiki with lots of this knowledge. |
Wiki documentation added here |
seems to fix the issue reported in #1097 & #1198