Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Select button in DagaGrid dose not support Dark Theme #1709

Closed
soi013 opened this issue Mar 24, 2020 · 3 comments · Fixed by #1711
Closed

All Select button in DagaGrid dose not support Dark Theme #1709

soi013 opened this issue Mar 24, 2020 · 3 comments · Fixed by #1711
Labels

Comments

@soi013
Copy link
Contributor

soi013 commented Mar 24, 2020

When HeadersVisibility of a DataGrid is All, a button to select all rows and columns is displayed.
However, if I select Dark-Theme, the color of the button remains the same as Light-Theme.

At Dark-Theme
スクリーンショット 2020-03-24 22 36 00

At Light-Theme
スクリーンショット 2020-03-24 22 36 19

Sample code is here

<Window
   x:Class="MaterialDesignDataGridTest.MainWindow"
   xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
   xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
   xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
   Width="300" Height="250">
   <Window.Resources>
      <materialDesign:BundledTheme BaseTheme="Dark"
         PrimaryColor="DeepPurple" SecondaryColor="Lime" />
   </Window.Resources>
   <DataGrid HeadersVisibility="All">
      <DataGrid.Columns>
         <DataGridTextColumn Binding="{Binding Text}" Header="Text" />
      </DataGrid.Columns>
      <TextBlock Text="AAA" />
      <TextBlock Text="BBB" />
      <TextBlock Text="CCC" />
   </DataGrid>
</Window>
@soi013
Copy link
Contributor Author

soi013 commented Mar 24, 2020

#61 may be related to this Issue.
However, I'm not sure what #61 means.

@Keboo Keboo added the bug label Mar 25, 2020
@w-syss
Copy link
Contributor

w-syss commented Mar 25, 2020

I am currently investigating

w-syss added a commit to w-syss/MaterialDesignInXamlToolkit that referenced this issue Mar 25, 2020
The select all button had a non dynamic background, which made theming difficult. With this change, the button behaves more in line with other elements.
w-syss added a commit to w-syss/MaterialDesignInXamlToolkit that referenced this issue Mar 25, 2020
The select all button had a non dynamic background, which made theming difficult. With this change, the button behaves more in line with other elements.
@w-syss
Copy link
Contributor

w-syss commented Mar 25, 2020

I created a pull request which resolves this

@Keboo Keboo linked a pull request Mar 29, 2020 that will close this issue
Keboo added a commit that referenced this issue Mar 29, 2020
* Fix #1709

The select all button had a non dynamic background, which made theming difficult. With this change, the button behaves more in line with other elements.

* Adding example in demo app

Co-authored-by: Kevin Bost <kitokeboo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants