Improve duplicate handling #1668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed IgnoreDuplicate to ShowAlways. Added MessageExpired method. Added appropriate Equals method. Added autogenerated GetHashCode method. ShowAlways more closely represented what that property actually does. IgnoreDuplicate is not very telling in the context of a SnachkBarMessageQueueItem. MessageExpired serves as a helper to determine if a message already exceeded it's duration. Equals and HashCode simplify comparisons of SnackBarMessageQueueItems, especially useful in the determining if a message is a duplicate.
Changed IgnoreDuplicate to DiscardDuplicates This reflects the changes to the Snackbar. Negating the selection is not necessary anymore.
Changed IgnoreDuplicate to DiscardDuplicates. Extracted message checking. These changes improve readability of the SnackbarMessage filtering.
|
I suppose I can agree with that. Nice work. Could I get you tempted to write a few tests to see that duplicates are properly discarded depending on different content and actioncommands? |
Keboo
reviewed
Feb 22, 2020
|
Thank you for you advice. I will add unit tests. |
Removed null check for value type. Improved null handling in Equals. Simplyfied GetHashCode.
|
I added |
This helps testing the SnackbarMessageQueue.
These are some basic unit tests for the SnackbarMessageQueue. This commit only tests the GetSnackbarMessage method if it handles duplicates and null values correctly.
Updated NuGet dependency
Keboo
approved these changes
Mar 2, 2020
|
@w-syss I apologize it has taken so long to get to the 4.0.0 release. Do you mind revisiting this PR and seeing about updating it so it can be merged? |
|
Sure, just give me a couple of days. |
|
This is resolved by #2240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was very confused when using the IgnoreDuplicate Property of the SnackBar as it did the exact opposite of what i expected it to do. I think the wording "IgnoreDuplicate" implies that duplicates are in fact ignored and not that the IgnoreDuplicate property is ignored.
These changes aim to clarify what these properties actually do, along with a bit of simplification in the comparison logic.
I am aware that breaking the public API might not be the best idea, however I think this clarification is a good QoL change.