WIP: Cleanup codebase #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuck-alt-delete
requested changes
Mar 13, 2023
src/kafka/producer.ts
Outdated
| }); | ||
|
|
||
| if (global.debug) { | ||
| console.log(`Connecting to Kafka producer...`); |
There was a problem hiding this comment.
Should be "Connecting to Kafka broker...", right?
Co-authored-by: Chuck Larrieu Casias <87353672+chuck-alt-delete@users.noreply.github.com>
chuck-alt-delete
approved these changes
Mar 13, 2023
bobbyiliev
approved these changes
Mar 14, 2023
This was referenced Mar 14, 2023
Merged
recursethis
pushed a commit
to recursethis/materialize-datagen
that referenced
this pull request
Feb 26, 2024
Co-authored-by: Chuck Larrieu Casias <87353672+chuck-alt-delete@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This is an attempt to begin cleaning up the codebase by adding new abstractions around formats and Kafka. This does break the Jest tests, but honestly, I'm not sure how useful those are.
Related Tickets & Documents
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?