Fix issue 79 #80
Merged
Fix issue 79 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjwiesman
approved these changes
Mar 14, 2023
recursethis
pushed a commit
to recursethis/materialize-datagen
that referenced
this pull request
Feb 26, 2024
* fix bug * remove unneeded file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
PR #78 broke avro / schema registry functionality. Tests didn't fail because we had
process.exit(0)instead ofprocess.exit(1)in a couple places. That functionality is restored and moved intoavroFormat.ts.I refactored logic having to do with topic names (eg schema subjects, prefixes) into
generateMegaRecord.tsso it only has to be handled in one place.I'd like to also refactor
generateMegaRecord.tsto turnMegaRecordinto a proper class, but that can be done in a separate PR.Related Tickets & Documents
closes #79
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?