Document how to bin/scratch launched items into Grafana #10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quodlibetor
force-pushed
the
doc-scratch-grafana
branch
from
12f85c8
to
6509ede
Compare
benesch
approved these changes
Feb 1, 2022
ruchirK
approved these changes
Feb 2, 2022
doc/developer/scratch.md
Outdated
| to observe the instance. | ||
| * `purpose`: is used as a filter in the Grafana UI. You can use this to group all your instances | ||
| (e.g. set it to `myname-debugging`) or set it to `load-test` or `benchmark`. | ||
| * `test` is both used by scratch to determine which test to execute, and displays as an additional |
There was a problem hiding this comment.
wait so just to double check - if the value of test doesn't match whats actually run in the launch script will that be a problem? I couldn't tell if the test field was purely informational and it seems like no?
There was a problem hiding this comment.
Test is used to determine what test to automatically run by the scratch script. If it is invalid then nothing will be run automatically.
There was a problem hiding this comment.
Test is used to determine what test to automatically run by the scratch script.
Hrm, are you sure? Where are you seeing that? Am I just missing it?
There was a problem hiding this comment.
Ah, no I must have been remembering the way it used to work, or just wrong.
The existing docs had examples that were correct, but there was no documentation for exactly what was required, making it difficult to be sure that everything worked if you were building something from, ahem, scratch.
quodlibetor
force-pushed
the
doc-scratch-grafana
branch
from
9ec2953
to
a0b315d
Compare
wangandi
pushed a commit
to wangandi/materialize
that referenced
this pull request
Apr 11, 2022
…nc#10382) The existing docs had examples that were correct, but there was no documentation for exactly what was required, making it difficult to be sure that everything worked if you were building something from, ahem, scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing docs had examples that were correct, but there was no
documentation for exactly what was required, making it difficult to be sure
that everything worked if you were building something from, ahem, scratch.
Checklist