Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: exclude scalar table funcs from select * #10597

Merged
merged 1 commit into from
Feb 10, 2022
Merged

sql: exclude scalar table funcs from select * #10597

merged 1 commit into from
Feb 10, 2022

Conversation

maddyblue
Copy link
Contributor

Scalar table functions plan into the FROM scope, but weren't excluding themselves from it.

Fixes MaterializeInc/database-issues#3078

Motivation

  • This PR fixes a recognized bug: MaterializeInc/database-issues#3078

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR adds a release note for any user-facing behavior changes.

@maddyblue maddyblue merged commit 431bd6c into MaterializeInc:main Feb 10, 2022
@maddyblue maddyblue deleted the table-func-star branch February 10, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

@sploiselle sploiselle Awaiting requested review from sploiselle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddyblue @benesch