storage: don't drop append futures when there's an error #14000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how errors are handled while appending multiple updates at once: instead of eagerly failing and cancelling all pending futures in case one fails, wait until all of them are finished, handle successes and then failures separately. Also return the IDs of all failed appends, instead of just selecting the first.
aljoscha
approved these changes
Aug 1, 2022
Co-authored-by: Aljoscha Krettek <mail@aljoscha.dev>
Co-authored-by: Aljoscha Krettek <mail@aljoscha.dev>
3 tasks
andrioni
added a commit
to andrioni/materialize
that referenced
this pull request
Aug 1, 2022
This was made unnecessary via MaterializeInc#13902 and MaterializeInc#14000.
andrioni
added a commit
to andrioni/materialize
that referenced
this pull request
Aug 1, 2022
This was made unnecessary via MaterializeInc#13902 and MaterializeInc#14000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how errors are handled while appending multiple updates at once: instead of eagerly failing and cancelling all pending futures in case one fails, wait until all of them are finished, handle successes and then failures separately.
Also return the IDs of all failed appends, instead of just selecting the first.
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protobuflabel.