-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add platform checks for RANGE type #18709
test: add platform checks for RANGE type #18709
Conversation
This is an unrelated regression that has been fixed on |
4d956e4
to
b3eaec9
Compare
bc49669
to
7e61da6
Compare
return [ | ||
Testdrive(dedent(s)) | ||
for s in [ | ||
manipulation.replace("$view_name$", "range_view1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good and in fact quite readable, so please do leave it as it is, but for the record the same can be achieved with format strings:
return [ Testdrive(f" range_view{i} ") for i in [1,2]]
or something along those ines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good and does what was needed from this test!
7e61da6
to
4a9edab
Compare
#18817 has been merged, rebased on |
4a9edab
to
0f63945
Compare
Motivation
Add platform checks for RANGE types. This fixes #17815.
Status
This is a draft (see comments).