Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist: skip truncate_bytes/strings proptests in miri #18808

Merged
merged 1 commit into from
Apr 17, 2023
Merged

persist: skip truncate_bytes/strings proptests in miri #18808

merged 1 commit into from
Apr 17, 2023

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Apr 17, 2023

They're too slow.

Motivation

  • This PR refactors existing code.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@danhhz danhhz requested a review from jkosh44 April 17, 2023 20:45
@danhhz danhhz requested a review from a team as a code owner April 17, 2023 20:45
jkosh44
jkosh44 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhhz
Copy link
Contributor Author

danhhz commented Apr 17, 2023

TFTR!

@danhhz danhhz enabled auto-merge April 17, 2023 20:46
@danhhz danhhz merged commit d2ddcc1 into MaterializeInc:main Apr 17, 2023
@danhhz danhhz deleted the ci branch April 17, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkosh44 jkosh44 jkosh44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danhhz @jkosh44