Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Add parsing for grant/revoke privileges #18811

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Apr 18, 2023

This commit adds the parsing and documentation for the privilege variant of the GRANT and REVOKE commands. The actual implementation is left for a later commit.

Part of #11579

Motivation

This PR adds a known-desirable feature.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

This commit adds the parsing and documentation for the privilege
variant of the GRANT and REVOKE commands. The actual implementation is
left for a later commit.

Part of MaterializeInc#11579
@jkosh44 jkosh44 force-pushed the parse-grant-revoke-privilege branch from 3565a75 to 20a8fac Compare April 18, 2023 01:12
@jkosh44 jkosh44 marked this pull request as ready for review April 18, 2023 01:45
@jkosh44 jkosh44 requested review from a team as code owners April 18, 2023 01:45
@jkosh44 jkosh44 requested a review from def- April 18, 2023 01:45
src/sql/src/catalog.rs Outdated Show resolved Hide resolved
@jkosh44
Copy link
Contributor Author

jkosh44 commented Apr 18, 2023

I'm going to go ahead and merge this so I can do some rebasing locally. We can fix any docs issues in a alter PR.

@jkosh44 jkosh44 merged commit 4c51076 into MaterializeInc:main Apr 18, 2023
@jkosh44 jkosh44 deleted the parse-grant-revoke-privilege branch April 18, 2023 21:14
@chaas chaas mentioned this pull request Apr 19, 2023
@jkosh44 jkosh44 mentioned this pull request Apr 24, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants