Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Use exclamation mark to mark uncovered lines #18836

Merged
merged 1 commit into from
Apr 19, 2023
Merged

coverage: Use exclamation mark to mark uncovered lines #18836

merged 1 commit into from
Apr 19, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 19, 2023

As suggested by Philip

! is clearer than the - used by default.

Motivation

  • This PR adds a feature that has not yet been specified.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

philip-stoev
philip-stoev approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You even regenerated the screenshot. Lesser humans would have absolutely let that slide.

@def- def- force-pushed the pr-exclamation-mark-coverage branch from 142a1cc to 04f5a60 Compare April 19, 2023 09:31
@def- def- enabled auto-merge April 19, 2023 09:31
@def- def- merged commit 57afcce into MaterializeInc:main Apr 19, 2023
@def- def- deleted the pr-exclamation-mark-coverage branch April 19, 2023 12:20
@materialize-bot materialize-bot mentioned this pull request Apr 21, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-stoev philip-stoev philip-stoev approved these changes

@nrainer-materialize nrainer-materialize nrainer-materialize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@def- @philip-stoev @nrainer-materialize