Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Fix for removed f-strings #18860

Merged
merged 1 commit into from
Apr 20, 2023
Merged

python: Fix for removed f-strings #18860

merged 1 commit into from
Apr 20, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 20, 2023

Forgot to switch the escaped {{}} strings which are sent to testdrive, follow-up to #18821
As seen in nightly: https://buildkite.com/materialize/nightlies/builds/2234#01879bdc-9ae4-4bf8-9c15-c02d0ac7a505

Motivation

  • This PR fixes a previously unreported bug.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def- def- changed the title python: Fix removed f-strings python: Fix for removed f-strings Apr 20, 2023
philip-stoev
philip-stoev approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. As soon as Nightly passes just merge it in.

@def-
python: Fix removed f-strings
4cde383 
Forgot to switch the escaped {{}} strings which are sent to testdrive,
follow-up to MaterializeInc#18821
@def- def- merged commit cec14de into MaterializeInc:main Apr 20, 2023
@def- def- deleted the pr-f-string-followup branch April 20, 2023 09:21
@materialize-bot materialize-bot mentioned this pull request Apr 21, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-stoev philip-stoev philip-stoev approved these changes

@nrainer-materialize nrainer-materialize nrainer-materialize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@def- @philip-stoev @nrainer-materialize