python: Remove unnecessary f-strings #18821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehume
approved these changes
Apr 18, 2023
nrainer-materialize
approved these changes
Apr 19, 2023
|
+1 for enabling the linter rule |
philip-stoev
approved these changes
Apr 19, 2023
|
It was just a quick grep after I noticed it a few times randomly before. |
|
New commit with the linter rule added. |
nrainer-materialize
approved these changes
Apr 19, 2023
We could also enable pylint's f-string-without-interpolation / W1309 https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/f-string-without-interpolation.html
Has been disabled since the start: MaterializeInc#7845
def-
added a commit
to def-/materialize
that referenced
this pull request
Apr 20, 2023
Forgot to switch the escaped {{}} strings which are sent to testdrive,
follow-up to MaterializeInc#18821
5 tasks
def-
added a commit
to def-/materialize
that referenced
this pull request
Apr 20, 2023
Forgot to switch the escaped {{}} strings which are sent to testdrive,
follow-up to MaterializeInc#18821
def-
added a commit
to def-/materialize
that referenced
this pull request
Apr 21, 2023
Forgot to switch the escaped {{}} strings which are sent to testdrive,
follow-up to MaterializeInc#18821
5 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also enable something like pylint's f-string-without-interpolation / W1309
https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/f-string-without-interpolation.html
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.