Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: in NULL-key error message, give hint for resolving it #18887

Merged
merged 1 commit into from
Apr 21, 2023
Merged

storage: in NULL-key error message, give hint for resolving it #18887

merged 1 commit into from
Apr 21, 2023

Conversation

aljoscha
Copy link
Contributor

Motivation

At least one user was confused about what to do.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@aljoscha aljoscha requested review from morsapaes and a team April 21, 2023 09:07
@aljoscha aljoscha requested a review from morsapaes April 21, 2023 09:11
morsapaes
morsapaes approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@morsapaes morsapaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this so swiftly! LGTM. 🙇‍♀️

@aljoscha aljoscha merged commit c65dc06 into MaterializeInc:main Apr 21, 2023
@aljoscha aljoscha deleted the storage-upsert-hint branch April 21, 2023 10:29
@aljoscha
Copy link
Contributor Author

thanks for the quick review!

@materialize-bot materialize-bot mentioned this pull request Apr 21, 2023
Closed
12 tasks
@morsapaes morsapaes mentioned this pull request Apr 23, 2023
Open
@guswynn guswynn mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morsapaes morsapaes morsapaes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aljoscha @morsapaes