Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Fix another removed f-string #18891

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 21, 2023

Forgot to switch the escaped {{}} strings which are sent to testdrive, follow-up to #18821

Fell over in https://buildkite.com/materialize/nightlies/builds/2242#0187a103-823b-4734-81ed-c91e454c3184

Motivation

  • This PR fixes a previously unreported bug.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

Forgot to switch the escaped {{}} strings which are sent to testdrive,
follow-up to MaterializeInc#18821
@def- def- merged commit 0c8ea1a into MaterializeInc:main Apr 21, 2023
@def- def- deleted the pr-f-string-followup-2 branch April 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants