storage: write status updates in the controller, and add the "paused" status #23222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guswynn
force-pushed
the
status-writes-in-controller
branch
2 times, most recently
from
c216f05
to
b8f148d
Compare
guswynn
changed the title
|
This PR has higher risk. Make sure to carefully review the file hotspots. In addition to having a knowledgeable reviewer, it may be useful to add observability and/or a feature flag. What's This?
Buggy File Hotspots:
|
guswynn
force-pushed
the
status-writes-in-controller
branch
2 times, most recently
from
436a008
to
de6cfae
Compare
petrosagg
reviewed
Nov 16, 2023
|
Test coverage looks good (build: https://buildkite.com/materialize/coverage/builds/317). |
guswynn
force-pushed
the
status-writes-in-controller
branch
2 times, most recently
from
a1609ba
to
24ef729
Compare
guswynn
changed the title
guswynn
force-pushed
the
status-writes-in-controller
branch
from
24ef729
to
7b90226
Compare
petrosagg
reviewed
Nov 22, 2023
guswynn
force-pushed
the
status-writes-in-controller
branch
from
7b90226
to
107fc3c
Compare
|
@petrosagg I think I resolved the last of your comments! |
guswynn
force-pushed
the
status-writes-in-controller
branch
from
107fc3c
to
c18c7cc
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #19792
@rkrishn7 thank you for you work on #20735 ! I have rebased and adapted that code here.
This pr shifts where we write status updates for sources and sinks into the storage controller; this reduces contention on those history shards, but also allows us to easily mark sources and sinks as "paused" when there exists no replica (note that we could have done this in a more hacky way, but chose not to)
this pr attempts to make the
pausedstatus as understandable as possible, but some edge cases will be improved when #23013 is implemented.Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.