Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Try using stdbuf with tee #24064

Merged
merged 1 commit into from
Dec 21, 2023
Merged

ci: Try using stdbuf with tee #24064

merged 1 commit into from
Dec 21, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Dec 21, 2023

tee seems change buffering behavior, we want each line to be in the right spot timing-wise

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def-
ci: Try using stdbuf with tee
1220ebe 
tee seems change buffering behavior, we want each line to be in the
right spot timing-wise
@def- def- marked this pull request as ready for review December 21, 2023 11:39
@def- def- requested a review from a team as a code owner December 21, 2023 11:39
philip-stoev
philip-stoev approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I wish there was a way to set it once and for all for the entire buildkite at the i2 level, but I can not find such a way.

Maybe we should open a ticket with Buildkite for the CloudFormation template to allow buildkite-agent to be called in the context of stdbuf

@def- def- merged commit 81674a8 into MaterializeInc:main Dec 21, 2023
67 checks passed
@def- def- deleted the pr-stdbuf branch December 21, 2023 16:00
@materialize-bot materialize-bot mentioned this pull request Dec 28, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-stoev philip-stoev philip-stoev approved these changes

@nrainer-materialize nrainer-materialize Awaiting requested review from nrainer-materialize

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @philip-stoev