Reduce the amount of duplicate code in per-dataflow-worker metrics #7690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing this requires is to de-strictify the rejection of missing_docs on the dataflow crate, until the PR at Soft/enum-kinds#3 goes in. |
antifuchs
force-pushed
the
asf/oaoo-commands-processed-metrics
branch
from
add0492
to
30b1298
Compare
benesch
reviewed
Aug 4, 2021
antifuchs
commented
Aug 4, 2021
antifuchs
force-pushed
the
asf/oaoo-commands-processed-metrics
branch
2 times, most recently
from
7cbcb6e
to
82d57e7
Compare
antifuchs
changed the title
benesch
approved these changes
Aug 4, 2021
By combining enum_kinds and num_enum, we can change the worker command representation to be an array of counters & values by which we increment them. That reduces the number of names we have to duplicate in code, and requires one fewer match statement on Command variants. It also gets rid of some metrics that were represented but never got incremented.
antifuchs
force-pushed
the
asf/oaoo-commands-processed-metrics
branch
from
82d57e7
to
8dfab6a
Compare
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of duplicate names you have to type if you introduce a
Commandto the dataflow server, and reduces the number of metrics that are present but never get updated. We do this by making the cache/counters live on an array and index that array by the Command kind that was processed.