Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the amount of duplicate code in per-dataflow-worker metrics #7690

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Reduce the amount of duplicate code in per-dataflow-worker metrics #7690

merged 1 commit into from
Aug 4, 2021

Commits on Aug 4, 2021

  1. Rework per-worker CommandProcessedMetrics to reduce duplicate code 

    By combining enum_kinds and num_enum, we can change the worker command
representation to be an array of counters & values by which we increment
them. That reduces the number of names we have to duplicate in code, and
requires one fewer match statement on Command variants.

It also gets rid of some metrics that were represented but never got
incremented.
    @antifuchs
    antifuchs committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    8dfab6a View commit details
    Browse the repository at this point in the history