Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elasticsearch-dsl requirement from ~=6.4 to >=6.4,<8.0 #218

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on elasticsearch-dsl to permit the latest version.

Changelog

Sourced from elasticsearch-dsl's changelog.

7.1.0 (2019-10-23)

  • Optimistic concurrent control for Document.delete
  • Removing deprecated DocType
  • Proper count caching for ES 7.x
  • Support for multiplexer token filter
  • Don't substitute for __ in FacetedSearch

7.0.0 (2019-04-26)

  • Compatibility with Elasticsearch 7.x
  • Document.save() now returns "created" or "updated"
  • Dropped support for Python 2.6, 3.2, and 3.3
  • When using fields the values are no longer merged into the body of the document and have to be accessed via .meta.fields only

6.4.0 (2019-04-26)

  • Index.document now correctly sets the Document's _index only when using default index ([#1091](https://github.com/elasticsearch/elasticsearch-dsl-py/issues/1091))
  • Document inheritance allows overriding Object and Nested field metadata like dynamic
  • adding auto_date_histogram aggregation
  • Do not change data in place when (de)serializing

6.3.1 (2018-12-05)

  • Analyzer.simulate now supports built-in analyzers
  • proper (de)serialization of the Range wrapper
  • Added search_analyzer to Completion field

6.3.0 (2018-11-21)

  • Fixed logic around defining a different doc_type name.
  • Added retry_on_conflict parameter to Document.update.
  • fields defined on an index are now used to (de)serialize the data even when not defined on a Document
  • Allow Index.analyzer to construct the analyzer
  • Detect conflict in analyzer definitions when calling Index.analyzer
  • Detect conflicting mappings when creating an index
  • Add simulate method to analyzer object to test the analyzer using the _analyze API.
  • Add script and script_id options to Document.update
  • Facet can now use other metric than doc_count
  • Range objects to help with storing and working with _range fields
  • Improved behavior of Index.save where it does a better job when index already exists
  • Composite aggregations now correctly support multiple sources aggs
  • UpdateByQuery implementated by @emarcey

6.2.1 (2018-07-03)

... (truncated)
Commits
  • 24abee3 Version bump to 7.1.0
  • 2c099d5 Adding RankFeature and RankFeature
  • 38f2f5e adding distance feature query
  • 4f63b2d Fixing the link to CLA
  • e74ab2c Do not allow __ to dot expansion in FacetedSearch
  • 89200d2 Adding parent aggregation
  • d77ee3b Allow proper definitions of multiplexer and conditional token filters
  • e1b4653 Explain example in docs
  • ec9f9c0 Merge branch 'master' into connection_interface_usage
  • 2b63582 Fixes count cache logic according to 7.x API
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build label Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          42       42           
  Lines        1892     1892           
=======================================
  Hits         1649     1649           
  Misses        243      243
Flag Coverage Δ
#unittests 87.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3de5b0...cb00c21. Read the comment docs.

Updates the requirements on [elasticsearch-dsl](https://github.com/elasticsearch/elasticsearch-dsl-py) to permit the latest version.
- [Release notes](https://github.com/elasticsearch/elasticsearch-dsl-py/releases)
- [Changelog](https://github.com/elastic/elasticsearch-dsl-py/blob/master/Changelog.rst)
- [Commits](elastic/elasticsearch-dsl-py@6.4.0...7.1.0)

Update CI requirements.txt

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: Casper Welzel Andersen <casper.andersen@epfl.ch>
@CasperWA CasperWA force-pushed the dependabot/pip/master/elasticsearch-dsl-gte-6.4-and-lt-8.0 branch from 4819f00 to cb00c21 Compare March 9, 2020 16:06
@CasperWA CasperWA self-requested a review March 9, 2020 16:06
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the changelog, it seems the major version change was due to added support for Elasticsearch of the same version (v7).
This seems in accordance with their documentation.

Hence, this change will allow Elasticsearch v6 and later, whereas before it was limited to Elasticsearch v6.
Finally, changing to elasticsearch-dsl~=7.1 would also be incorrect, since it would be the equivalent of elasticsearch-dsl>=7.1; <8.0. One could then do elasticsearch-dsl~=6, but one would have to add the condition of being minimum 6.4.0 anyway, so moving away from tilde notation here, makes the most sense.

@CasperWA CasperWA merged commit fe05bd3 into master Mar 9, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/pip/master/elasticsearch-dsl-gte-6.4-and-lt-8.0 branch March 9, 2020 16:27
@ml-evs ml-evs mentioned this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant