Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.0 release #228

Merged
merged 1 commit into from Mar 13, 2020
Merged

v0.7.0 release #228

merged 1 commit into from Mar 13, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 13, 2020

This PR prepares another minor release that includes the changes from this week.

Breaking changes:

New features:

Bug fixes:

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #228 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files          43       43           
  Lines        1916     1916           
=======================================
  Hits         1678     1678           
  Misses        238      238           
Flag Coverage Δ
#unittests 87.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5569bda...acdbdf9. Read the comment docs.

@ml-evs ml-evs requested a review from CasperWA March 13, 2020 18:41
@ml-evs
Copy link
Member Author

ml-evs commented Mar 13, 2020

Looks like I managed to tag the wrong commit for release (i.e. the one in this PR, not the resulting merge commit). Apologies! Assuming there are no other problems I will amend the commit message with the contents of the PR description, so just make sure that we rebase this PR.

This does seem like a problem, the PyPI release was created without anyone else reviewing the PR... I was under the impression it was only looking for commits to master?

@CasperWA
Copy link
Member

Looks like I managed to tag the wrong commit for release (i.e. the one in this PR, not the resulting merge commit). Apologies! Assuming there are no other problems I will amend the commit message with the contents of the PR description, so just make sure that we rebase this PR.

Yup - first PR, then merge, then tag on master and git push --tags. But no worries. Maybe I should write a wiki page with the steps I usually follow?

This does seem like a problem, the PyPI release was created without anyone else reviewing the PR... I was under the impression it was only looking for commits to master?

No. It looks for tags in the repo.
We should probably be more stringent about it for sure.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good though, cheers 👍 I'll merge it.

@CasperWA CasperWA merged commit acdbdf9 into master Mar 13, 2020
@CasperWA CasperWA deleted the up_to_v0.7.0 branch March 13, 2020 19:34
@ltalirz ltalirz temporarily deployed to optimade March 13, 2020 19:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants