Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GH Action to validate OPTiMaDe instances #224

Merged

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Mar 12, 2020

Closes #223

Use Materials-Consortia/optimade-validator-action instead in CI.

Also, use the new validator version to pass the sha of either the "merge commit", i.e., the latest head commit in a PR, no matter where the head is, or the sha of the latest push commit (since the CI workflow is also triggered when pushing to master).

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #224 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          43       43           
  Lines        1912     1912           
=======================================
  Hits         1674     1674           
  Misses        238      238           
Flag Coverage Δ
#unittests 87.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636476c...4796f62. Read the comment docs.

@CasperWA CasperWA force-pushed the close_223_remove_validator_action branch 2 times, most recently from 56d60d6 to 85d000b Compare March 12, 2020 15:44
@CasperWA
Copy link
Member Author

Currently, the docker-image test is failing due to #225 not being merged.

@CasperWA CasperWA force-pushed the close_223_remove_validator_action branch from 85d000b to caac296 Compare March 12, 2020 17:55
@CasperWA CasperWA marked this pull request as ready for review March 12, 2020 17:55
@CasperWA CasperWA requested review from ml-evs and shyamd March 12, 2020 17:55
@CasperWA
Copy link
Member Author

@shyamd You can also incorporate this PR into your restructuring if you wish - keeping it a separate commit in the end?

@shyamd
Copy link
Contributor

shyamd commented Mar 12, 2020

Yeah, I'm gonna close that PR and rebuild from scratch. Too many things are in flux.

shyamd
shyamd previously approved these changes Mar 12, 2020
@CasperWA
Copy link
Member Author

By the way, this cannot be merged until #225 is merged.

Use Materials-Consortia/optimade-validator-action instead in CI.
Add usage of `validator version` to ensure the latest changes that may
be introduced in a PR are properly tested.
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, nice job @CasperWA! Do you want to merge the outstanding action PR first so we have a v1(.1?) run of the action here?

.github/workflows/deps_lint.yml Show resolved Hide resolved
@CasperWA
Copy link
Member Author

Happy with this, nice job @CasperWA! Do you want to merge the outstanding action PR first so we have a v1(.1?) run of the action here?

Again, the idea is to always point to v1, and then just update that tag - which means the two application should be completely separate... well, as separate as one pointing to the other can be ... :)

@CasperWA CasperWA merged commit 2ed7f74 into Materials-Consortia:master Mar 13, 2020
@CasperWA CasperWA deleted the close_223_remove_validator_action branch March 13, 2020 14:20
@ml-evs ml-evs mentioned this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put GH Action in separate repo
3 participants