New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GH Action to validate OPTiMaDe instances #224
Remove GH Action to validate OPTiMaDe instances #224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 43 43
Lines 1912 1912
=======================================
Hits 1674 1674
Misses 238 238
Continue to review full report at Codecov.
|
56d60d6
to
85d000b
Compare
Currently, the docker-image test is failing due to #225 not being merged. |
85d000b
to
caac296
Compare
@shyamd You can also incorporate this PR into your restructuring if you wish - keeping it a separate commit in the end? |
Yeah, I'm gonna close that PR and rebuild from scratch. Too many things are in flux. |
By the way, this cannot be merged until #225 is merged. |
Use Materials-Consortia/optimade-validator-action instead in CI.
Add usage of `validator version` to ensure the latest changes that may be introduced in a PR are properly tested.
caac296
to
4796f62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this, nice job @CasperWA! Do you want to merge the outstanding action PR first so we have a v1(.1?) run of the action here?
Again, the idea is to always point to v1, and then just update that tag - which means the two application should be completely separate... well, as separate as one pointing to the other can be ... :) |
Closes #223
Use Materials-Consortia/optimade-validator-action instead in CI.
Also, use the new
validator version
to pass thesha
of either the "merge commit", i.e., the latest head commit in a PR, no matter where the head is, or thesha
of the latest push commit (since the CI workflow is also triggered when pushing tomaster
).