Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add txt-files in optimade.validator.data to MANIFEST #225

Merged
merged 1 commit into from Mar 12, 2020
Merged

Add txt-files in optimade.validator.data to MANIFEST #225

merged 1 commit into from Mar 12, 2020

Conversation

CasperWA
Copy link
Member

Also added to test_setup.py test.

I found this error, since I couldn't install the latest commit when testing Materials-Consortia/optimade-validator-action#4

@CasperWA CasperWA added bug Something isn't working tests Related to tests labels Mar 12, 2020
@CasperWA CasperWA requested review from ml-evs and shyamd March 12, 2020 15:50
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #225 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          43       43           
  Lines        1912     1912           
=======================================
  Hits         1674     1674           
  Misses        238      238
Flag Coverage Δ
#unittests 87.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5e903...260f2fe. Read the comment docs.

@CasperWA CasperWA added the priority/high Issue or PR with a consensus of high priority label Mar 12, 2020
@CasperWA CasperWA mentioned this pull request Mar 12, 2020
Merged
ml-evs
ml-evs approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, assume this is no problem for #214.

@CasperWA
Copy link
Member Author

Thanks for catching this, assume this is no problem for #214.

It seems he will start over 😮

@CasperWA CasperWA merged commit 636476c into Materials-Consortia:master Mar 12, 2020
@CasperWA CasperWA deleted the add_txt_to_MANIFEST branch March 12, 2020 18:32
@ml-evs ml-evs mentioned this pull request Mar 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@shyamd shyamd Awaiting requested review from shyamd

Assignees
No one assigned
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority tests Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CasperWA @ml-evs