Validator improvements #515
Conversation
ml-evs
force-pushed
the
ml-evs/validator_improvements
branch
3 times, most recently
from
7acf4c4
to
6020edc
Compare
ml-evs
added
blocked
ml-evs
force-pushed
the
ml-evs/validator_improvements
branch
from
fbcfd4a
to
b5a073e
Compare
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 91.51% 91.67% +0.15%
==========================================
Files 62 62
Lines 3135 3182 +47
==========================================
+ Hits 2869 2917 +48
+ Misses 266 265 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ml-evs
force-pushed
the
ml-evs/validator_improvements
branch
from
b5a073e
to
4ede5b2
Compare
ml-evs
removed
the
blocked
ml-evs
force-pushed
the
ml-evs/validator_improvements
branch
3 times, most recently
from
2f3c1a4
to
5615abc
Compare
| new_entry = entry.dict(exclude_unset=False) | ||
| for field in ("relationships", "links", "meta", "type", "id"): | ||
| if field in new_entry and new_entry[field] is None: | ||
| del new_entry[field] |
There was a problem hiding this comment.
Can you not use the exclude_none parameter here?
There was a problem hiding this comment.
Unfortunately not: the problem is that we want to include None values from all entry properties, but not from these top-level response fields. I'm sure there is a neater way of doing this, but I'd rather be explicit for now as its hopefully only a temporary "fix" before it can be dealt with properly in #504.
|
I'll give @CasperWA until tomorrow to have a look if he wants to, if not I'll merge in the morning. |
Yeah, this one got a bit out of hand, but think it would have been more annoying as multiple PRs. I'll rebase this one into a few feature commits to maintain some kind of structure. |
ml-evs
force-pushed
the
ml-evs/validator_improvements
branch
from
fc63615
to
a70b0d2
Compare
- when getting a "chosen entry" - when making a request of SHOULD/OPTIONAL fields of entry endpoints - improved error handling of chosen_entry and empty endpoints - Until None valued response fields are applied based on the entry schema and the response fields query parameter, return all unset fields with exclude_unset=False when handling response fields (should be dealt with in #504)
ml-evs
force-pushed
the
ml-evs/validator_improvements
branch
from
a70b0d2
to
9681f86
Compare
Closes #514, supercedes #513
Blocked by #503.
This PR fixes the above problems, and tidies some of the
@test_casedecorator into theValidatorResultsclass.ValidatorResults&test_casechosen_entryquery (closes 'Chosen entry had no value for ...' when property is not requested #514)exclude_unsetwhen handling query params. This will need a proper treatment based on the actual requested fields, pending Responses for unknown fields #504...