Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for elasticsearch filtertransformer comparision operators. #648

Merged
merged 1 commit into from Dec 24, 2020

Conversation

markus1978
Copy link
Contributor

With the current elasticsearch filtertransformer some of the optimade-validator checks fail due to buggy comparison operators. This fixes it.

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #648 (d546133) into master (ffbe0fb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files          60       60           
  Lines        3257     3257           
=======================================
  Hits         3038     3038           
  Misses        219      219           
Flag Coverage Δ
project 93.27% <100.00%> (ø)
validator 66.13% <0.00%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/filtertransformers/elasticsearch.py 87.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbe0fb...d546133. Read the comment docs.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @markus1978!

I'm going to be adding elasticsearch to the CI as a proper backend between #613 and a future PR. (see my comment in #339, apologies for closing that one early!)

@ml-evs ml-evs merged commit e15ae92 into Materials-Consortia:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants