Use venv #15
Merged
Use venv #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct how we get get version information
We need to set the current working directory before running "setup.py develop"!
TiagoCavalcante
requested changes
Sep 6, 2021
| indent_style = space | ||
| indent_size = 4 | ||
| end_of_line = lf | ||
| insert_final_newline = true |
There was a problem hiding this comment.
This is not necessary as [*] already contains it.
There was a problem hiding this comment.
If [*] changes then there are cascaded and possibly unintended effects.
Therefore in general, I'd prefer to be explicit over implicit. (In other words, I am not trying to "optimize" the length of the configuration file. Instead, I am trying to optimize clarity and unambiguity.)
| end_of_line = lf | ||
| insert_final_newline = true | ||
|
|
||
| [*.py] |
There was a problem hiding this comment.
I think it is better to add quote_type = double.
There was a problem hiding this comment.
That makes sense. Should be added in c7f0274
TiagoCavalcante
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should address #11