Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bit_length and machine precision #107

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Use bit_length and machine precision #107

merged 1 commit into from
Jan 10, 2022

Conversation

rocky
Copy link
Member

@rocky rocky commented Jan 10, 2022

Use bit_length() and machine_precision

These two items suggested by mmatera.

I am not certain though if this fully addresses the concerns, so double check.

@rocky
Use bit_length() and machine_precision
57665f0 
These two items suggested by mmatera
@rocky rocky mentioned this pull request Jan 10, 2022
Merged
@mmatera mmatera merged commit 914cbbd into fix_103 Jan 10, 2022
TiagoCavalcante
TiagoCavalcante reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@TiagoCavalcante TiagoCavalcante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems your code is correct to me.

@rocky rocky deleted the fix_103-machine-precision branch February 20, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiagoCavalcante TiagoCavalcante TiagoCavalcante left review comments

@mmatera mmatera Awaiting requested review from mmatera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rocky @TiagoCavalcante @mmatera