Remove "value" from Symbol; add SymbolConstant... #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from PredefinedConstant. Doc strings have been over.
rocky
commented
Jan 3, 2023
| @@ -485,7 +485,7 @@ def format_operator(operator) -> Union[String, BaseElement]: | |||
| return op | |||
| return operator | |||
|
|
|||
| precedence = prec.value | |||
| precedence = prec.value if hasattr(prec, "value") else 0 | |||
There was a problem hiding this comment.
@rocky, maybe it would be better to set the default to 670 (which is the default for precedence).
There was a problem hiding this comment.
0 means no parenthesis ever. 670 adds a parenthesis for everything except Get <<.
So restating, are you sure we want parenthesis most of the time?
There was a problem hiding this comment.
OK, in that case, let's keep 0...
There was a problem hiding this comment.
In another PR we may add a constant named "NEVER_ADD_PARENTHESIS". There was more refactoring oef the parenthesize function going on in #691
|
I will let this sit for a day, and if there are no comments or objections, I'll merge. |
|
Regarding this PR, I agree that Symbols should not have a "value" property. |
mmatera
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from PredefinedConstant.
Doc strings have been over.
This includes some of the stuff from #691. I think there is a little other stuff from that which should go in. But this narrows the differences.