Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace named characters with plain text before printing the output #20

Closed
wants to merge 2 commits into from

Conversation

GarkGarcia
Copy link
Contributor

We should replace named-characters in the output strings before they get printed. This was implemented in #13 but it wasn't copied to #17.

@GarkGarcia GarkGarcia requested a review from rocky January 26, 2021 16:14
@GarkGarcia GarkGarcia added the enhancement New feature or request label Jan 26, 2021
@GarkGarcia GarkGarcia marked this pull request as draft January 28, 2021 21:08
@GarkGarcia
Copy link
Contributor Author

We still to figure out how to replace the characters inside of error messages.

@GarkGarcia
Copy link
Contributor Author

We still to figure out how to replace the characters inside of error messages.

Fixed on aaf8cbc

@GarkGarcia GarkGarcia marked this pull request as ready for review January 28, 2021 22:07
@GarkGarcia
Copy link
Contributor Author

It's worth noting that this should not be merged if we decide to merge mathics/Mathics#1136

@rocky
Copy link
Member

rocky commented Jan 31, 2021

We decided not to do this.

@rocky rocky closed this Jan 31, 2021
@TiagoCavalcante TiagoCavalcante deleted the unicode-replace-output branch July 27, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants