optional servername via config #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2024
|
Thanks for this. Generally the assumption was that the server name and host is the same thing. However given that they can be different. I think simply extending Qui client with an additional optional If it is passed, it is used as the server name. However host also could be a hostname... So let's see. |
|
I'll have a deeper look into it when I have a free moment. |
|
Bump, feels like a very small change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add possibility to provide servername via config.
This needs to be configurable for example in solana tpu transactions, where the servername has to be a specific string
Issues Fixed
partial fix of:
#98 (comment)