Skip to content

Commit

Permalink
fix: Fix Core CKF segfault with fitted params (acts-project#3203)
Browse files Browse the repository at this point in the history
This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily.

acts-project#3161 also cleans this up by having tracks for each branch instead of last tip states
  • Loading branch information
andiwand authored and Matthew Harris committed Jun 18, 2024
1 parent e952d0d commit 1b17e2f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ class CombinatorialKalmanFilter {
ACTS_ERROR("Error while acquiring bound state for target surface: "
<< res.error() << " " << res.error().message());
result.lastError = res.error();
} else {
} else if (!result.activeTips.empty()) {
const auto& fittedState = *res;
std::size_t currentTip = result.activeTips.back().first;
// Assign the fitted parameters
Expand Down

0 comments on commit 1b17e2f

Please sign in to comment.