Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure MasterBotArgs into ConfigFile that contains Bot/Webserver configs #76

Open
Jokler opened this issue Oct 18, 2020 · 0 comments
Labels
good first issue Good for newcomers improvement Something is not as good as it could be
Milestone

Comments

@Jokler
Copy link
Member

Jokler commented Oct 18, 2020

Is your feature request related to a problem? Please describe.
Currently the MasterBotArgs struct acts as the config file for the webserver too.

Describe the solution you'd like
The webserver configuration should be separate from the bot config with the config file being defined by a struct that contains both.

Additional context
Relevant lines of code:

#[derive(Debug, Serialize, Deserialize)]
pub struct MasterArgs {
#[serde(default = "default_name")]
pub master_name: String,
pub address: String,
pub channel: Option<String>,
#[serde(default = "default_verbose")]
pub verbose: u8,
pub domain: String,
pub bind_address: String,
pub webserver_enable: bool,
pub names: Vec<String>,
pub id: Option<Identity>,
pub ids: Option<Vec<Identity>>,
}

@Jokler Jokler added good first issue Good for newcomers improvement Something is not as good as it could be labels Oct 18, 2020
@Jokler Jokler added this to the 0.3.0 milestone Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Something is not as good as it could be
Projects
None yet
Development

No branches or pull requests

1 participant