Encode element with empty key, empty element, and attributes #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 73.87% 73.94% +0.06%
==========================================
Files 46 46
Lines 2431 2437 +6
==========================================
+ Hits 1796 1802 +6
Misses 635 635
Continue to review full report at Codecov.
|
MaxDesiatov
changed the title
MaxDesiatov
reviewed
Aug 3, 2021
| @@ -217,9 +217,16 @@ struct XMLCoderElement: Equatable { | |||
| _ string: inout String, | |||
| _ charactersEscapedInAttributes: [(String, String)] | |||
| ) { | |||
| let actuallyAttributes = self.elements.filter { | |||
| $0.key.isEmpty && $0.elements.isEmpty && !$0.attributes.isEmpty | |||
There was a problem hiding this comment.
is key a critical check here? Maybe your original case fails because of the key value intrinsic feature described here? https://github.com/MaxDesiatov/XMLCoder#coding-key-value-intrinsic
MaxDesiatov
requested changes
Aug 5, 2021
MaxDesiatov
approved these changes
Aug 5, 2021
MaxDesiatov
reviewed
Aug 5, 2021
… into chore/emptyKeyAttributev2
WOW you are toooo quick! haha.. I removed the ignore swift lint, and just reduced the name so that it is under 200 characters, thanks! |
spotlightishere
pushed a commit
to WiiLink24/XMLCoder
that referenced
this pull request
Aug 6, 2021
…ice#223) Fixes an edge case with intrinsic value key encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original description is in this issue:
#224